Fix CI #63
Merged
Fix CI #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp242
force-pushed
the
ci
branch
2 times, most recently
from
502cd9d
to
401d781
Compare
==================
WARNING: DATA RACE
Write at 0x00c000394018 by goroutine 10:
github.com/fsnotify/fsevents.TestIssue48()
/Users/runner/work/fsevents/fsevents/fsevents_test.go:137 +0xcc6
testing.tRunner()
/Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1259 +0x22f
testing.(*T).Run·dwrap·21()
/Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1306 +0x47
Previous read at 0x00c000394018 by goroutine 12:
github.com/fsnotify/fsevents.TestIssue48.func1()
/Users/runner/work/fsevents/fsevents/fsevents_test.go:112 +0x1d2
Goroutine 10 (running) created at:
testing.(*T).Run()
/Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1306 +0x726
testing.runTests.func1()
/Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1598 +0x99
testing.tRunner()
/Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1259 +0x22f
testing.runTests()
/Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1596 +0x7ca
testing.(*M).Run()
/Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1504 +0x9d1
main.main()
_testmain.go:55 +0x22b
Goroutine 12 (finished) created at:
github.com/fsnotify/fsevents.TestIssue48()
/Users/runner/work/fsevents/fsevents/fsevents_test.go:107 +0x815
testing.tRunner()
/Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1259 +0x22f
testing.(*T).Run·dwrap·21()
/Users/runner/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1306 +0x47
==================
Experience with fsnotify has shown this can be an issue, and the tests here seem fast enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update gofmt, some outdated patterns.